Handle soft fail for s3keysensor #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
force-pushed
the
handle_soft_fail
branch
from
76ba793
to
9488397
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 90 90
Lines 5368 5377 +9
=======================================
+ Hits 5292 5301 +9
Misses 76 76
☔ View full report in Codecov by Sentry. |
pankajastro
force-pushed
the
handle_soft_fail
branch
from
d01fad0
to
77eac18
Compare
pankajastro
requested review from
phanikumv,
pankajkoti,
Lee-W,
sunank200 and
utkarsharma2
as code owners
pankajastro
commented
Jun 5, 2023
pankajastro
force-pushed
the
handle_soft_fail
branch
from
b4cd2a0
to
1317ab8
Compare
pankajastro
force-pushed
the
handle_soft_fail
branch
from
1317ab8
to
807585c
Compare
pankajkoti
reviewed
Jun 5, 2023
pankajkoti
approved these changes
Jun 5, 2023
pankajkoti
reviewed
Jun 5, 2023
|
|
Merging this but feel free to raise any concerns I will address them separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if soft_fail is set to true then raise AirflowSkipException. We may need to replicate this to other sensor too
closes: #1149