New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle check_fn in S3KeySensor #1171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way to serialize python callable - stackoverflow
There are some security issues with pickle so maybe we can't use always |
ed71172
to
eba2242
Compare
eba2242
to
9696d8f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 90 90
Lines 5377 5381 +4
=======================================
+ Hits 5301 5305 +4
Misses 76 76
☔ View full report in Codecov by Sentry. |
I've discussed this with @uranusjr . It seems pickle won't work and the current solution might be good enough. Please correct me if I'm wrong. Thanks! |
closes: #1166