Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle check_fn in S3KeySensor #1171

Merged
merged 3 commits into from Jun 12, 2023
Merged

Handle check_fn in S3KeySensor #1171

merged 3 commits into from Jun 12, 2023

Conversation

pankajastro
Copy link
Contributor

closes: #1166

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to serialize python callable - stackoverflow

@pankajastro
Copy link
Contributor Author

Another way to serialize python callable - stackoverflow

There are some security issues with pickle so maybe we can't use always

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ebb00d0) 98.58% compared to head (545db4c) 98.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1171   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          90       90           
  Lines        5377     5381    +4     
=======================================
+ Hits         5301     5305    +4     
  Misses         76       76           
Impacted Files Coverage Δ
astronomer/providers/amazon/aws/sensors/s3.py 100.00% <100.00%> (ø)
astronomer/providers/amazon/aws/triggers/s3.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pankajastro pankajastro marked this pull request as ready for review June 6, 2023 19:38
@Lee-W
Copy link
Contributor

Lee-W commented Jun 12, 2023

Another way to serialize python callable - stackoverflow

There are some security issues with pickle so maybe we can't use always

I've discussed this with @uranusjr . It seems pickle won't work and the current solution might be good enough. Please correct me if I'm wrong. Thanks!

@pankajastro pankajastro merged commit a4569fc into main Jun 12, 2023
10 checks passed
@pankajastro pankajastro deleted the handle_check_fn branch June 12, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check_fn not being used correctly in S3KeySensorAsync
3 participants