Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(databricks): get jod_id from job_name for DatabricksRunNowOperatorAsync #1254

Merged

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Jul 24, 2023

This fixes the issue that job_name is passed without job_id and gets {"error_code":"INVALID_PARAMETER_VALUE","message":"Job 0 does not exist."} error

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +28.35 🎉

Comparison is base (afd7a1f) 70.21% compared to head (5b5f0c5) 98.57%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1254       +/-   ##
===========================================
+ Coverage   70.21%   98.57%   +28.35%     
===========================================
  Files          43       90       +47     
  Lines        2528     5396     +2868     
===========================================
+ Hits         1775     5319     +3544     
+ Misses        753       77      -676     
Impacted Files Coverage Δ
...nomer/providers/databricks/operators/databricks.py 98.83% <83.33%> (-1.17%) ⬇️

... and 68 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lee-W Lee-W force-pushed the get-job-id-from-job-name-for-DataBricksRunNowOperatorAsync branch from 4f38d15 to b72a9fe Compare July 24, 2023 14:33
@Lee-W Lee-W marked this pull request as ready for review July 24, 2023 14:39
@Lee-W Lee-W merged commit 3eb6daf into main Jul 24, 2023
10 checks passed
@Lee-W Lee-W deleted the get-job-id-from-job-name-for-DataBricksRunNowOperatorAsync branch July 24, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants