Fix impersonation failure on GKE start pod operator async #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
fix-impersonation-failure-on-GKEStartPodOperatorAsync
branch
from
e40bccb
to
9b9ea6a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
=======================================
Coverage 98.57% 98.58%
=======================================
Files 91 91
Lines 5404 5428 +24
=======================================
+ Hits 5327 5351 +24
Misses 77 77
☔ View full report in Codecov by Sentry. |
Lee-W
force-pushed
the
fix-impersonation-failure-on-GKEStartPodOperatorAsync
branch
4 times, most recently
from
3d53c13
to
7c7181c
Compare
|
It works fine on my side. But would like to mark it as "Ready for review" after testing by CRE. |
phanikumv
reviewed
Aug 3, 2023
Lee-W
force-pushed
the
fix-impersonation-failure-on-GKEStartPodOperatorAsync
branch
6 times, most recently
from
d2986d5
to
dc1bdb2
Compare
Lee-W
requested review from
pankajastro,
pankajkoti,
sunank200 and
utkarsharma2
as code owners
Lee-W
force-pushed
the
fix-impersonation-failure-on-GKEStartPodOperatorAsync
branch
2 times, most recently
from
d55a242
to
84f2308
Compare
|
|
pankajkoti
reviewed
Aug 11, 2023
| @@ -13,7 +13,7 @@ RUN apt-get install -y --no-install-recommends \ | |||
| echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] http://packages.cloud.google.com/apt cloud-sdk main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list && \ | |||
| curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key --keyring /usr/share/keyrings/cloud.google.gpg add - && \ | |||
| apt-get update -y && \ | |||
| apt-get install google-cloud-sdk -y && \ | |||
| apt-get install python3 google-cloud-sdk -y && \ | |||
There was a problem hiding this comment.
Why did we need python3 here? Does it not come with the base image?
There was a problem hiding this comment.
Not sure about the base image, but without this. It doesn't work on my local machine
Lee-W
force-pushed
the
fix-impersonation-failure-on-GKEStartPodOperatorAsync
branch
4 times, most recently
from
f4e6a0d
to
df411d6
Compare
Lee-W
changed the title
Lee-W
force-pushed
the
fix-impersonation-failure-on-GKEStartPodOperatorAsync
branch
from
df411d6
to
6278686
Compare
pankajastro
approved these changes
Aug 16, 2023
phanikumv
deleted the
fix-impersonation-failure-on-GKEStartPodOperatorAsync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the issue?
The argument
impersonation_chaindoes not work. The operator still uses the gcp_conn to start the pod.What's changed
We suspect the issue is due to that the token is not correctly generated. Thus, we try to write this token into kube_config