Call S3 sensor check_fn only with file size attribute #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 90 90
Lines 5393 5394 +1
=======================================
+ Hits 5316 5317 +1
Misses 77 77
☔ View full report in Codecov by Sentry. |
pankajastro
requested review from
phanikumv,
pankajkoti,
Lee-W,
sunank200 and
utkarsharma2
as code owners
Lee-W
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1213
Airflow S3Sensor and astronomer-provider S3SensorAsync call check_fn param with different param. This PR restrict S3SensorAsync to call check_fn with the same param as in the Airflow sensor