add keep_response parameter to HttpHookAsync #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
keep-aiohttp-session
branch
2 times, most recently
from
55ed786
to
25d7827
Compare
Lee-W
requested review from
phanikumv,
pankajastro,
pankajkoti,
sunank200 and
utkarsharma2
as code owners
Lee-W
changed the title
Lee-W
force-pushed
the
keep-aiohttp-session
branch
from
a34b6bd
to
658812f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1330 +/- ##
==========================================
+ Coverage 98.53% 98.55% +0.01%
==========================================
Files 91 91
Lines 5450 5456 +6
==========================================
+ Hits 5370 5377 +7
+ Misses 80 79 -1
☔ View full report in Codecov by Sentry. |
Lee-W
force-pushed
the
keep-aiohttp-session
branch
2 times, most recently
from
a7afd82
to
618f3f0
Compare
for more information, see https://pre-commit.ci
Lee-W
force-pushed
the
keep-aiohttp-session
branch
from
cd0908f
to
6386a77
Compare
Lee-W
force-pushed
the
keep-aiohttp-session
branch
from
af54576
to
fd82241
Compare
for more information, see https://pre-commit.ci
phanikumv
reviewed
Sep 25, 2023
Co-authored-by: Phani Kumar <94376113+phanikumv@users.noreply.github.com>
Lee-W
force-pushed
the
keep-aiohttp-session
branch
from
89051aa
to
f604a54
Compare
phanikumv
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add keep_response parameter to HttpHookAsync to allow user to use the response after running HttpHookAsync.run
closes: #1321