Handle ClientConnectorError to allow for retries #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RNHTTR
requested review from
phanikumv,
pankajastro,
pankajkoti,
Lee-W,
sunank200 and
utkarsharma2
as code owners
pankajastro
approved these changes
Oct 9, 2023
Lee-W
approved these changes
Oct 11, 2023
|
@Lee-W can you try to fix the mypy failure so that we can get this merged to main |
|
ok |
|
Fixed the databricks issue. other failures are blocked by #1341 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
=======================================
Coverage 98.56% 98.57%
=======================================
Files 91 91
Lines 5454 5458 +4
=======================================
+ Hits 5376 5380 +4
Misses 78 78
☔ View full report in Codecov by Sentry. |
Currently, if the API call results in a `ClientConnectorError`, it won't be properly handled, and it won't be eligible for retries. This adds the `ClientConnectorError` to the exceptions that trigger the databricks retry block.
kaxil
approved these changes
Oct 31, 2023
pankajastro
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the API call results in a
ClientConnectorError, it won't be properly handled, and it won't be eligible for retries. This adds theClientConnectorErrorto the exceptions that trigger the databricks retry block.