Pinning connexion==2.14.2 due to issue with latest release version3.0.0 #1354
Conversation
vatsrahul1001
requested review from
phanikumv,
pankajastro,
pankajkoti,
Lee-W,
sunank200 and
utkarsharma2
as code owners
|
Another option is to have |
| @@ -75,7 +75,7 @@ ENV PATH $PATH:$JAVA_HOME/bin::$HIVE_HOME/bin:$HADOOP_HOME/bin | |||
| COPY astronomer-providers /tmp/astronomer-providers | |||
| RUN python3 -m pip install --upgrade pip | |||
| # Ideally we should install using constraints file | |||
| RUN pip install --upgrade --force-reinstall --no-cache-dir /tmp/astronomer-providers[all] | |||
| RUN pip install --upgrade --no-cache-dir /tmp/astronomer-providers[all] | |||
There was a problem hiding this comment.
The problem with this would be that latest provider code from main would not be installed as it would already come installed with the runtime image and that would be non-latest.
There was a problem hiding this comment.
may I know please what problem are we trying to solve? are we encountering some new issue that we did not before as this has been like this since quite a while, no?
There was a problem hiding this comment.
@pankajkoti correct, and we want these deployment with the main code
There was a problem hiding this comment.
@pankajkoti more context here
There was a problem hiding this comment.
okay, are we sure if it's that or the line below causing the reinstall of Airflow?
RUN pip install apache-airflow[slack]
How about we try changing this line instead to RUN pip install apache-airflow-providers-slack instead of removing the force reinstall?
There was a problem hiding this comment.
As per CI logs its getting installed because of reinstall of airflow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 91 91
Lines 5458 5458
=======================================
Hits 5380 5380
Misses 78 78 ☔ View full report in Codecov by Sentry. |
vatsrahul1001
force-pushed
the
remove-force-install
branch
from
f646255
to
45a48ea
Compare
vatsrahul1001
changed the title
Pinning connexion==2.14.2 due to issue with latest release version3.0.0
more context:https://astronomer.slack.com/archives/C01UJJEN0P3/p1699003495317799