Pass parameters to parent class in SnowflakeSensorAsync
#1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the SnowflakeSensorAsync does not propagate `parameters` to its parent class, SqlSensor. Because of this, `parameters` are not passed for execution and can cause task failures when doing so.
josh-fell
requested review from
phanikumv,
pankajastro,
pankajkoti,
Lee-W,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 94 94
Lines 4636 4636
=======================================
Hits 4559 4559
Misses 77 77 ☔ View full report in Codecov by Sentry. |
Lee-W
approved these changes
Apr 30, 2024
pankajkoti
reviewed
Apr 30, 2024
pankajkoti
approved these changes
Apr 30, 2024
|
@Lee-W perhaps we need to make a release for astronomer-providers after merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the SnowflakeSensorAsync does not propagate
parametersto its parent class, SqlSensor. Because of this,parametersare not passed for execution and can cause task failures when attempting doing so.