Exclude files containing dead links #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feluelle
requested review from
phanikumv,
bharanidharan14,
rajaths010494,
pankajastro and
pankajkoti
as code owners
Codecov Report
@@ Coverage Diff @@
## main #587 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 72 72
Lines 3957 3957
=======================================
Hits 3887 3887
Misses 70 70 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rajaths010494
approved these changes
Aug 16, 2022
pankajkoti
reviewed
Aug 16, 2022
| @@ -39,6 +39,8 @@ repos: | |||
| rev: v3.10.2 | |||
| hooks: | |||
| - id: markdown-link-check | |||
| # Ignoring files containing dead links which are actually not dead. | |||
| exclude: dev/README.md|CODE_OF_CONDUCT.md | |||
There was a problem hiding this comment.
I believe we should not exclude these files here as that would beat the purpose of the markdown-link-check pre-commit check then. Can we check if something else is wrong if the links are not actually dead or if there is some issue with the pre-commit hook itself?
There was a problem hiding this comment.
I agree. This was only being done to unblock other PRs. We should find a way to fix the markdown issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.