-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use poke_interval
instead of poll_interval
for sensor
#640
Conversation
poll_interval
to poke_interval
poke_interval
instead of poll_interval
for sensot
poke_interval
instead of poll_interval
for sensotpoke_interval
instead of poll_interval
for sensor
Codecov ReportBase: 98.30% // Head: 98.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
+ Coverage 98.30% 98.31% +0.01%
==========================================
Files 79 79
Lines 4131 4166 +35
==========================================
+ Hits 4061 4096 +35
Misses 70 70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks overall good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have inconsistent variables names poll_interval
and polling_period_seconds
. Let's rename all these to poke_interval
in all the internal implementation across execute
methods in operators
& sensors
and in triggers
. We can keep the user facing variable poll_interval
in the operator & sensor __init__
methods until we remove it.
We will also need to modify the docstring params upon renaming.
4279e2a
to
7d06dc9
Compare
8c8e622
to
19c1065
Compare
19c1065
to
7a81117
Compare
- Added deprecated warning and used poke_interval instead of poll_interval
- Rename `poll_interval` to `poke_interval` for all internal occurrences of sensors
Fix emr sensor
Add TODO for test case Fix pre-commit
7a81117
to
60464bb
Compare
Added deprecated warning and used
poke_interval
where everpoll_interval
is used in the sensor.closes: #613