Fix session token from extra config #730
Conversation
bharanidharan14
requested review from
phanikumv,
rajaths010494,
pankajastro and
pankajkoti
as code owners
Codecov ReportBase: 98.48% // Head: 98.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 86 86
Lines 4622 4625 +3
=======================================
+ Hits 4552 4555 +3
Misses 70 70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@rajaths010494 @pankajastro @phanikumv can you review this PR |
| @@ -65,6 +65,12 @@ async def get_client_async(self) -> AioBaseClient: | |||
| self.log.info("Retrieving region_name from Connection.extra_config['region_name']") | |||
| region_name = extra_config["region_name"] # pragma: no cover | |||
|
|
|||
| if "aws_session_token" in extra_config: | |||
| self.log.info( | |||
There was a problem hiding this comment.
in the sync version, they also log self.conn_repr https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/utils/connection_wrapper.py#L349
would it be possible to do similar logging here?
There was a problem hiding this comment.
We can do it, whatever the previous async log was there I followed the same. If we want to follow the same in sync version I need to change all the log in this file, So far now to fix this issue we can go ahead with this, we can cover this in #732
There was a problem hiding this comment.
As long we have a GitHub issue for it I'm ok.
when AWS secrete and access key is passed via the connection UI field the session token is not considered, when it is passed via extra config it is considered
closes: #725