Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RedshiftDataHook to accept access and secret keys from the connections object also. #746

Merged
merged 3 commits into from Nov 4, 2022
Merged

Fix RedshiftDataHook to accept access and secret keys from the connections object also. #746

merged 3 commits into from Nov 4, 2022

Conversation

bharanidharan14
Copy link
Contributor

@bharanidharan14 bharanidharan14 commented Nov 2, 2022 •
edited by rajaths010494

  • Consider access and secret key if it is passed in connection login and password field
  • Consider AWS session token if it is passed in extra_config

closes: #741

@codecov
Copy link

codecov bot commented Nov 2, 2022 •
edited

Codecov Report

Base: 98.48% // Head: 98.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4d07eac) compared to base (7923acd).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4d07eac differs from pull request most recent head 366ef79. Consider uploading reports for the commit 366ef79 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          86       86           
  Lines        4628     4634    +6     
=======================================
+ Hits         4558     4564    +6     
  Misses         70       70
Impacted Files Coverage Δ
...onomer/providers/amazon/aws/hooks/redshift_data.py 99.09% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bharanidharan14 bharanidharan14 marked this pull request as ready for review November 3, 2022 03:03
@bharanidharan14
Fix mypy issue
366ef79 
Fix test case
@bharanidharan14
Copy link
Contributor Author

@pankajastro @rajaths010494 Addressed your review comments, can you please take a look at it

@rajaths010494 rajaths010494 changed the title Fix redshift_data hook to considered access and secret key from the connections object not from extra Fix redshift_data hook to consider access and secret key from the connections object not from extra Nov 4, 2022
@bharanidharan14 bharanidharan14 merged commit f4b5db7 into main Nov 4, 2022
@bharanidharan14 bharanidharan14 deleted the bug-fix-741 branch November 4, 2022 07:37
@rajaths010494 rajaths010494 changed the title Fix redshift_data hook to consider access and secret key from the connections object not from extra Fix RedshiftDataHook to accept access and secret keys from the connections object also. Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajkoti pankajkoti pankajkoti approved these changes

@rajaths010494 rajaths010494 rajaths010494 approved these changes

@phanikumv phanikumv Awaiting requested review from phanikumv phanikumv is a code owner

@pankajastro pankajastro Awaiting requested review from pankajastro pankajastro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix redshift_data hook code to take access and secret key from the connections object not from extra
4 participants
@bharanidharan14 @pankajkoti @rajaths010494 @pankajastro