Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private key authentication for SFTPHookAsync via SFTP connection #749

Merged
merged 10 commits into from Dec 14, 2022

Conversation

bharanidharan14
Copy link
Contributor

@bharanidharan14 bharanidharan14 commented Nov 9, 2022

Added the SFTPSensorAsync example DAG into the master DAG, created the connection details via code and other details needed for the DAG to run as a self-sufficient

closes: #662 #760

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 98.50% // Head: 98.50% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4ab13a5) compared to base (584d99d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #749   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files          87       87           
  Lines        4753     4759    +6     
=======================================
+ Hits         4682     4688    +6     
  Misses         71       71           
Impacted Files Coverage Δ
astronomer/providers/sftp/hooks/sftp.py 98.71% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bharanidharan14
Copy link
Contributor Author

@rajaths010494 @phanikumv Addressed review comments

@bharanidharan14 bharanidharan14 changed the title Run SFTPSensorAsync in integrations tests Run SFTPSensorAsync in integrations tests and add support for private key authentication Dec 14, 2022
@bharanidharan14 bharanidharan14 changed the title Run SFTPSensorAsync in integrations tests and add support for private key authentication Run SFTPSensorAsync in integrations tests and add support for private key connection Dec 14, 2022
@bharanidharan14 bharanidharan14 merged commit 5d655dc into main Dec 14, 2022
@bharanidharan14 bharanidharan14 deleted the add-sftp-662 branch December 14, 2022 13:43
@bharanidharan14 bharanidharan14 changed the title Run SFTPSensorAsync in integrations tests and add support for private key connection Support private key authentication for SFTPHookAsync via SFTP connection Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run SFTPSensorAsync in integrations tests
4 participants