Remove redundant connection params from AwsBaseHookAsync
#758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharanidharan14
force-pushed
the
fix-aws-connection-details
branch
from
eb16a1d
to
40bc84f
Compare
Codecov ReportBase: 98.49% // Head: 98.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 98.49% 98.51% +0.01%
==========================================
Files 86 86
Lines 4658 4639 -19
==========================================
- Hits 4588 4570 -18
+ Misses 70 69 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bharanidharan14
requested review from
phanikumv,
rajaths010494,
pankajastro and
pankajkoti
as code owners
|
@rajaths010494 @pankajastro @pankajkoti @phanikumv Can you guys review this PR |
pankajkoti
approved these changes
Nov 16, 2022
Sure |
phanikumv
changed the title
AwsbaseHookAsync
phanikumv
changed the title
AwsbaseHookAsyncAwsBaseHookAsync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used
AwsConnectionWrapperfor getting the connection params which we don't need to cover the details from our end, it will cover all the missing params passed in the AWS connections. This will also cover removing the redundant.Closes: #732