Add autocommit = True in SnowflakeHookAsync
#767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajaths010494
requested review from
phanikumv,
bharanidharan14,
pankajastro and
pankajkoti
as code owners
phanikumv
changed the title
SnowflakeHookAsync
Codecov ReportBase: 98.50% // Head: 98.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
- Coverage 98.50% 98.48% -0.03%
==========================================
Files 86 86
Lines 4683 4682 -1
==========================================
- Hits 4613 4611 -2
- Misses 70 71 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
phanikumv
changed the title
SnowflakeHookAsyncSnowflakeHookAsync
phanikumv
approved these changes
Nov 18, 2022
bharanidharan14
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding auto-commit to true in the hook where we are connecting to the snowflake and running the queries.
closes #768