Enhance AwsBaseHookAsync to support assume role role_arn passed via extra_config in the airflow connection
#804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharanidharan14
force-pushed
the
aws-async-hook-786
branch
from
2e8365b
to
2681cce
Compare
bharanidharan14
changed the title
Codecov ReportBase: 98.50% // Head: 98.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 98.50% 98.51%
=======================================
Files 87 87
Lines 4759 4777 +18
=======================================
+ Hits 4688 4706 +18
Misses 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bharanidharan14
requested review from
phanikumv,
rajaths010494,
pankajastro and
pankajkoti
as code owners
|
@rajaths010494 @pankajastro @pankajkoti @phanikumv Can you review this PR |
pankajastro
reviewed
Dec 12, 2022
bharanidharan14
force-pushed
the
aws-async-hook-786
branch
from
33bd284
to
db7a68f
Compare
bharanidharan14
force-pushed
the
aws-async-hook-786
branch
from
db7a68f
to
4f52973
Compare
pankajastro
approved these changes
Dec 14, 2022
rajaths010494
approved these changes
Dec 14, 2022
bharanidharan14
changed the title
AwsBaseHookAsync to support assume role role_arn passed via extra_config in the airflow connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
aiobotocoredoesn't support assume role withrole_arn. Now added support for assuming role option inAwsBaseHookAsynccloses: #786