Fix KubernetesPodOperatorAsync to consider kubernetes connection id and details in trigger
#815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharanidharan14
requested review from
phanikumv,
rajaths010494,
pankajastro and
pankajkoti
as code owners
Codecov ReportBase: 98.51% // Head: 98.51% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 87 87
Lines 4777 4777
=======================================
Hits 4706 4706
Misses 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rajaths010494
approved these changes
Dec 16, 2022
|
@pankajastro @pankajastro @phanikumv Can you review this PR |
did we test this on astro cloud? |
Deployed the code changes in Astro cloud and tested it ran |
phanikumv
approved these changes
Dec 16, 2022
phanikumv
reviewed
Dec 16, 2022
bharanidharan14
changed the title
kubernetes_conn_id in trigger and hookKubernetesPodOperatorAsync to consider Kubernetes connection id and details in trigger
bharanidharan14
changed the title
KubernetesPodOperatorAsync to consider Kubernetes connection id and details in triggerKubernetesPodOperatorAsync to consider kubernetes connection id and details in trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube_config_pathorkube_config(JSON) from Kubernetes connection was not consider inKubernetesPodOperatorAsync. Because the connection id is set to None in the trigger, So now it is fixed to consider the Kubernetes connection id and details in trigger.closes: #745