New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_logs
, pod cleanup
and XCom push
in GKEStartPodOperatorAsync
#824
Conversation
Codecov ReportBase: 98.53% // Head: 98.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 98.53% 98.54% +0.01%
==========================================
Files 88 88
Lines 4845 4881 +36
==========================================
+ Hits 4774 4810 +36
Misses 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@pankajastro @pankajkoti @rajaths010494 @phanikumv Need review on this PR |
astronomer/providers/google/cloud/triggers/kubernetes_engine.py
Outdated
Show resolved
Hide resolved
astronomer/providers/google/cloud/operators/kubernetes_engine.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please share logs for all the points you've covered in this implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description isnt as per standards, and has typos. Please correct the same
a9619b7
to
bcfb02b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have a small question inline.
astronomer/providers/google/cloud/operators/kubernetes_engine.py
Outdated
Show resolved
Hide resolved
bcfb02b
to
f552655
Compare
GKEStartPodOperatorAsync
get_logs
, pod cleanup
and XCom push
in GKEStartPodOperatorAsync
@phanikumv Fixed it. Can you review it |
Description should be in imperative tense. Please correct it. |
Fix Issue: Support get_logs in GKEStartPodOperatorAsync #811 not showing pod's logs on completion if
get_logs
is TrueCurrently in
GKEStartPodOperatorAsync
, even though theget_logs
attribute is set to True it was not showing the pod's log as in sync operator as expected, now it is fixed extended support to conclude theget_logs
attribute once the trigger callback function is executed fetching the container logs from the pod manager ifget_logs
attribute is set to True.Fix Issue Improve GKEStartPodOperatorAsync #451 pod cleanup and XCom push
Once the trigger callback function is executed after the successful event. Pushed
pod name
andnamespace
and result in XCom whendo_xcom_push
is set to True and cleaning of the pod was also handled.Handle the
GKEStartPodOperatorAsync
status based on the terminal status. Status of GKEStartPodOperatorAsync should reflect pod status. #814Currently, GKEStartPodOperatorAsync (and GKEStartPodTrigger) succeeds whenever the pod's state is one of PodPhase.terminal_states, that is either Failed or Succeeded. So by adding condition in the trigger based on the terminal status and returning the failed even when the terminal status is in a failed state.
closes: #811 #451 #814