Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SnowflakeHookAsync when empty sql list is passed. #838

Merged
merged 4 commits into from Jan 24, 2023

Conversation

pankajastro
Copy link
Contributor

closes: #433

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 98.61% // Head: 98.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5daba0a) compared to base (97f0509).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #838   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          89       89           
  Lines        4970     4972    +2     
=======================================
+ Hits         4901     4903    +2     
  Misses         69       69           
Impacted Files Coverage Δ
astronomer/providers/snowflake/hooks/snowflake.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@park-peter
Copy link
Contributor

this will conflict with #810 as it changes the way SnowflakeHook returns the result to be in line with the non-deferrable hook. Please wait until #810 is merged.

@pankajastro pankajastro marked this pull request as ready for review January 23, 2023 18:03
@pankajastro pankajastro merged commit 6c6cfcd into main Jan 24, 2023
@pankajastro pankajastro deleted the fix_snowflake branch January 24, 2023 06:18
@pankajastro pankajastro added this to the 1.15.0 milestone Feb 1, 2023
@rajaths010494 rajaths010494 changed the title Snowflake handle empty sql list Handle Snowflake when empty sql list is passed. Feb 15, 2023
@rajaths010494 rajaths010494 changed the title Handle Snowflake when empty sql list is passed. Handle SnowflakeHookAsync when empty sql list is passed. Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error when SnowflakeHookAsync take empty list in sql param
3 participants