Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timeout instead of execution_timeout with ExternalTaskSensor when sensing task_id #858

Merged
merged 1 commit into from Jan 25, 2023

Conversation

rajaths010494
Copy link
Contributor

When an external task id is given ExternalTaskSensor is using execution_timeout instead of timeout from BaseSensorOperator.

closes #857

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 98.63% // Head: 98.63% // No change to project coverage 👍

Coverage data is based on head (922a6b9) compared to base (fc5b37a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          89       89           
  Lines        4974     4974           
=======================================
  Hits         4906     4906           
  Misses         68       68           
Impacted Files Coverage Δ
astronomer/providers/core/sensors/external_task.py 95.55% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phanikumv phanikumv merged commit f1899a7 into main Jan 25, 2023
@phanikumv phanikumv deleted the use_timeout branch January 25, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execution_timeout instead of timeout with ExternalTaskSensor when sensing task_id
2 participants