Fix read of Pandas json for S3 and GCS custom XCOM backend #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
requested review from
phanikumv,
rajaths010494,
pankajastro and
Lee-W
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 90 90
Lines 5011 5017 +6
=======================================
+ Hits 4942 4948 +6
Misses 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The downloaded file content from AWS and Google hook return bytes instance which the pandas read_json cannot read and hence we fix this by converting it to BytesIO instance which the pandas read_json method reads well. closes: #955
pankajkoti
force-pushed
the
fix-dataframe-custom-xcom
branch
from
51c911d
to
a3f5200
Compare
pankajastro
approved these changes
Apr 13, 2023
rajaths010494
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downloaded file content from AWS and Google hook return bytes instance which the pandas read_json cannot read; hence, we fix this by converting it to BytesIO instance which the pandas read_json method reads well.
closes: #955