Fix sagemaker operator for Amazon provider release 8.0.0 #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `find_processing_job_by_name` method on the Sagemaker hook has been replaced with `count_processing_jobs_by_name` and hence make the necessary changes for the release ensuring backward compatibility for the older versions of the provider. related to: #977
pankajkoti
requested review from
phanikumv,
pankajastro,
Lee-W,
sunank200 and
utkarsharma2
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 90 90
Lines 5078 5079 +1
=======================================
+ Hits 5009 5010 +1
Misses 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Please share the test results for pre-rc provider versions |
|
Successful DAG runs for older versions of the providers Successful DAG runs for RC versions of the providers |
phanikumv
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
find_processing_job_by_namemethod on the Sagemaker hook has been replaced withcount_processing_jobs_by_nameand hence make the necessary changes for the release ensuring backward compatibility for the older versions of the provider.related to: #977