Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to support new OAuth flow support in CLI #119

Closed
cwurtz opened this issue Jun 6, 2018 · 1 comment
Closed

Refactor to support new OAuth flow support in CLI #119

cwurtz opened this issue Jun 6, 2018 · 1 comment
Assignees
Milestone

Comments

@cwurtz
Copy link
Contributor

cwurtz commented Jun 6, 2018

Update astro auth login so it outputs a URL that direct the user to an orbit page to start the OAuth process. After that URL output it should await input of a token that user will eventually receive after authenticating.

This token should then be saved to the global config.

Exact details still TBD, but currently it is expected that all registry auth functionality should be stripped out. Depending on what options we have with docker auth, we'll either hardcode the username to something, and use the token as the password. Alternatively if we can set or pass the encoded user/pass, we can just pass the token.

@ryw
Copy link
Contributor

ryw commented Jun 11, 2018

Issue moved to astronomerio/astro-cli #75 via ZenHub

schnie pushed a commit that referenced this issue Jan 22, 2020
We have seen multiple customers in the past two weeks get their web server stuck in a crash loop because it takes too long for their webserver to spin up, crossing the failureThreshold and causing it to restart.

Without any changes to resources, increasing the `failureThreshold` from 10 to 30 solves this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants