Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancel event is swallowed #62

Closed
makepanic opened this issue Jul 22, 2019 · 1 comment · Fixed by #63
Closed

cancel event is swallowed #62

makepanic opened this issue Jul 22, 2019 · 1 comment · Fixed by #63

Comments

@makepanic
Copy link
Contributor

makepanic commented Jul 22, 2019 •
edited

pickr emits a cancel event when clicking the cancel button.

Sadly this isn't handled/proxied by ember-pickr.
I think it would be great to allow consumers to do something on cancel.

Oops seems like cancel and clear were added 22hrs ago in a release:

https://github.com/Simonwep/pickr/releases/tag/1.2.3

I'll create a PR to add support for these
makepanic added a commit to makepanic/ember-pickr that referenced this issue Jul 22, 2019
@makepanic
feat: call onClear, onCancel, onSwatchSelect actions if set
996dd75 
fixes astronomersiva#62
@makepanic makepanic mentioned this issue Jul 22, 2019
Merged
astronomersiva pushed a commit that referenced this issue Jul 22, 2019
@makepanic @astronomersiva
feat: call onClear, onCancel, onSwatchSelect actions if set
cf2bd47 
fixes #62
@astronomersiva
Copy link
Owner

haha, I was about to comment that after seeing the email notification 😆 Thanks for the quick PR though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: call onClear, onCancel, onSwatchSelect actions if set makepanic/ember-pickr
2 participants
@makepanic @astronomersiva