Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor based on hipscat v0.1.2 #117

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Refactor based on hipscat v0.1.2 #117

merged 1 commit into from
Aug 15, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Uses the new file_io.load_parquet_to_pandas method, and test-friendly pixel list construction of a Catalog.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #117 (450d826) into main (7ae05c0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          901       899    -2     
=========================================
- Hits           901       899    -2     
Files Changed Coverage Δ
src/hipscat_import/catalog/file_readers.py 100.00% <100.00%> (ø)
...cat_import/margin_cache/margin_cache_map_reduce.py 100.00% <100.00%> (ø)
src/hipscat_import/soap/map_reduce.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@maxwest-uw maxwest-uw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had one small comment about something that falls outside of the scope of this pr :) lgtm

src/hipscat_import/catalog/file_readers.py Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit 8e3314c into main Aug 15, 2023
14 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/012 branch August 15, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants