Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert default on resume check. #123

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Invert default on resume check. #123

merged 1 commit into from
Aug 21, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Related to issue #116 . Current behavior of the resume flag is kinda confusing.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #123 (1525da2) into main (450d826) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          899       900    +1     
=========================================
+ Hits           899       900    +1     
Files Changed Coverage Δ
src/hipscat_import/catalog/arguments.py 100.00% <100.00%> (ø)
src/hipscat_import/pipeline_resume_plan.py 100.00% <100.00%> (ø)
src/hipscat_import/soap/arguments.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@delucchi-cmu delucchi-cmu requested review from a team, drewoldag and maxwest-uw and removed request for a team and drewoldag August 21, 2023 12:31
@delucchi-cmu delucchi-cmu merged commit be30113 into main Aug 21, 2023
14 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/resume branch October 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants