Check for valid catalog directories. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 939 949 +10
=========================================
+ Hits 939 949 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
delucchi-cmu
added a commit
that referenced
this pull request
Oct 6, 2023
* unpin sphinx versions (#134) * Verification pipeline boilerplate (#126) * Verification pipeline boilerplate * Input catalog options. * Contribution docs updates. * Merge recent changes (#135) * Use minimum stage name formatting. * Run copier. * Add a tad more context for failure email. * Pin pandas version * Remove benchmarks for now. * unpin sphinx versions (#134) --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com> --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com> * Check for valid catalog directories. (#136) * Check for valid catalog directories. * Hit uncovered file check. --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Uses new
hipscat.io.validation.is_valid_catalogto check for basic catalog existence/validity for catalogs that are used for inputs to other import pipelines.Note that the smoke test is currently failing after the release of the above method. This PR aims to address the failing test, as well as augment existing passing checks.
Code Quality