Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PPT v1.4.3 #144

Merged
merged 3 commits into from Oct 11, 2023
Merged

Update to PPT v1.4.3 #144

merged 3 commits into from Oct 11, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Runs copier update to use new template version. Moves the new "getting started dev guide" to expand on environment setup instructions in the contribution guide.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #144 (9d3bea1) into main (8d1112f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          983       983           
=========================================
  Hits           983       983           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@OliviaLynn OliviaLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm a big fan of the new wording in the contributing section.

docs/guide/contributing.rst Outdated Show resolved Hide resolved
delucchi-cmu added a commit to lincc-frameworks/python-project-template that referenced this pull request Oct 11, 2023
Co-authored-by: Olivia R. Lynn <olynn@andrew.cmu.edu>
@delucchi-cmu
Copy link
Contributor Author

Looks good! I'm a big fan of the new wording in the contributing section.

It's right from the template. I'm sending you a PR to fix the grammar in the original!

@delucchi-cmu delucchi-cmu merged commit f697f2a into main Oct 11, 2023
13 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/copier branch October 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants