Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata files when creating datasets #189

Merged
merged 2 commits into from Dec 13, 2023
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Related to astronomy-commons/hipscat#147

  • Removes the partition_info.csv writing from catalog creation
  • Writes out _metadata files for all created datasets
  • Expands some tests to try loading the dataset after creation through import
  • Suppresses the progress bar output in more unit tests

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f50adee) 99.76% compared to head (aa9dca4) 99.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          27       27           
  Lines        1257     1273   +16     
=======================================
+ Hits         1254     1270   +16     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu marked this pull request as ready for review December 12, 2023 22:04
@delucchi-cmu delucchi-cmu merged commit c96627a into main Dec 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants