Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct integer types in index catalog creation #200

Merged
merged 1 commit into from Jan 10, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

In service of astronomy-commons/lsdb#108

Uses the new preferred uint8/uint64 integer types for the Norder/Dir/Npix partition info columns in a generated index catalog. Needed to also update the test data for the small sky test catalog to use the right integer types, and pulls the typing information from the resulting catalog's metadata file.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ba5bcb) 99.45% compared to head (abf6d9e) 99.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          29       29           
  Lines        1455     1459    +4     
=======================================
+ Hits         1447     1451    +4     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit abfc017 into main Jan 10, 2024
13 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/lsdb/108 branch January 11, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants