Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests that we can handle pathlib.Path. #235

Merged
merged 2 commits into from Feb 26, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Requires astronomy-commons/hipscat#219

Closes #228 , Closes #160.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (3df522f) to head (b772a64).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%     
==========================================
  Files          24       24              
  Lines        1204     1203       -1     
==========================================
- Hits         1201     1200       -1     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@delucchi-cmu delucchi-cmu merged commit b571ef8 into main Feb 26, 2024
8 of 9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/160/pathlib branch February 26, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pathlib.Path for CsvReader(schema_file) Support pathlib.Path for input_file_list
2 participants