New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force numpy array for passing to healpy. #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'm not sure if it is required to be changed, but there is also .values
in the lines 268-269 of the same file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 99.75% 99.75% -0.01%
==========================================
Files 24 24
Lines 1204 1203 -1
==========================================
- Hits 1201 1200 -1
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Added check that the generated hipscat_index values are good (since that's what happening in those lines in question). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Change Description
Closes #227.