Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force numpy array for passing to healpy. #236

Merged
merged 5 commits into from Feb 26, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #227.

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm not sure if it is required to be changed, but there is also .values in the lines 268-269 of the same file

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (3df522f) to head (58f50b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%     
==========================================
  Files          24       24              
  Lines        1204     1203       -1     
==========================================
- Hits         1201     1200       -1     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu
Copy link
Contributor Author

Added check that the generated hipscat_index values are good (since that's what happening in those lines in question).

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delucchi-cmu delucchi-cmu merged commit 9c890b2 into main Feb 26, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/227/dot-values branch February 26, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitting stage fails when using numpy_nullable backend
2 participants