Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If not resuming, remove intermediate dir. #244

Merged
merged 1 commit into from Feb 28, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #58. Closes #216 .

Solution Description

If the user specifies resume=False, then remove the intermediate directory instead of throwing an error. If we are resuming from prior state, give a warning (and catch this warning in testing, as it's a good indication that we've picked up some prior state and we're using it).

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (c0b3546) to head (6362618).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   99.75%   99.74%   -0.01%     
==========================================
  Files          24       24              
  Lines        1203     1198       -5     
==========================================
- Hits         1200     1195       -5     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@delucchi-cmu delucchi-cmu merged commit 89d0cf8 into main Feb 28, 2024
8 of 9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/58/clean branch February 28, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportArguments.resume=False still sets up a ResumePlan Add --clean option to import when resuming
2 participants