Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index generation improvements #248

Merged
merged 2 commits into from Mar 1, 2024
Merged

Index generation improvements #248

merged 2 commits into from Mar 1, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #206.

  • Performs the index de-duplication when reading from the original leaf file.
  • Pass the dask client and use explicitly for the compute call.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (c5af8dd) to head (4c58d76).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          24       24           
  Lines        1204     1204           
=======================================
  Hits         1201     1201           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit ea60042 into main Mar 1, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/index_gen branch March 1, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate better process of dropping duplicates in index generation
2 participants