Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to importer to support other table types. #65

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Apr 13, 2023

Includes:

  • catalog type in parameters
  • test data for a source catalog
  • fixes to map reduce to stop creating so many index columns
  • adds columns to output so data is later readable easily as a dask dataframe (Norder, Dir, and Npix)
  • write out the hipscat index field
  • increases to test coverage

Closes Issue #48

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #65 (c5e9055) into main (53c2cd5) will increase coverage by 0.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   98.30%   98.82%   +0.52%     
==========================================
  Files          10       10              
  Lines         412      427      +15     
==========================================
+ Hits          405      422      +17     
+ Misses          7        5       -2     
Impacted Files Coverage Δ
src/hipscat_import/catalog/arguments.py 99.00% <100.00%> (+2.19%) ⬆️
src/hipscat_import/catalog/map_reduce.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/run_import.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@delucchi-cmu delucchi-cmu requested review from a team and OliviaLynn and removed request for a team April 13, 2023 19:37
@delucchi-cmu delucchi-cmu linked an issue Apr 13, 2023 that may be closed by this pull request
Copy link
Member

@OliviaLynn OliviaLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delucchi-cmu delucchi-cmu merged commit 83e6cdb into main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Tables - basic support
2 participants