Prefactor for alternate table import arguments. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delucchi-cmu
requested review from
a team and
smcguire-cmu
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 98.82% 99.10% +0.28%
==========================================
Files 10 11 +1
Lines 427 449 +22
==========================================
+ Hits 422 445 +23
+ Misses 5 4 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
smcguire-cmu
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of arguments that will be used for creating indexes and equijoin association tables. This pulls those arguments, their validation logic, and the provenance info generation into a parent class.
This should simplify the new classes, as well as reducing duplicated code (which pylint was VERY unhappy about).