Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oldest testing #164

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Feb 14, 2023

Adds testing for the oldest declared dependencies of asdf-astropy.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #164 (ce8deed) into main (4acfd57) will increase coverage by 0.63%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   98.73%   99.37%   +0.63%     
==========================================
  Files          52       52              
  Lines        1903     1909       +6     
==========================================
+ Hits         1879     1897      +18     
+ Misses         24       12      -12     
Impacted Files Coverage Δ
...tropy/converters/transform/tests/test_transform.py 97.84% <100.00%> (+0.77%) ⬆️
asdf_astropy/converters/transform/core.py 100.00% <0.00%> (+8.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WilliamJamieson WilliamJamieson marked this pull request as ready for review February 14, 2023 20:01
Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WilliamJamieson WilliamJamieson merged commit 1b40863 into astropy:main Feb 15, 2023
@WilliamJamieson WilliamJamieson deleted the feature/oldest_testing branch February 15, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants