Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop oldest supported numpy from build-system #193

Merged
merged 2 commits into from Aug 18, 2023

Conversation

WilliamJamieson
Copy link
Contributor

This is superfluous and was never needed.
It appears to have come from copy/paste from the old astropy package template

This is superfluous and was never needed.
It appears to have come from copy/paste from the old astropy package template
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #193 (835a0eb) into main (0ab96f6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          55       55           
  Lines        2046     2046           
=======================================
  Hits         2018     2018           
  Misses         28       28           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@pllim pllim merged commit a53ed69 into astropy:main Aug 18, 2023
37 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/python-3.12 branch August 18, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants