Removing the astroplan sites module (which migrated to astropy) #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The astroplan
sites
module was added in #45, and then ported to astropy in astropy/astropy#4042. Since then, we've been meaning to remove the now redundant sites machinery from astroplan. In this PR, I removed the sites module and associated tests.In addition, I had to create a new monkey patch. Many of the tests for the
astroplan.Observer
class used the class methodastroplan.Observer.at_site
to efficiently resolve coordinates for an observatory with the original sites module. Since the original sites module had a local copy of the site database stored offline, the tests written withastroplan.Observer.at_site
would function identically in tests with or without the--remote-data
flag. Now that we're usingEarthLocation.of_site
under the hood which always accesses the internet, I had to monkey-patch theEarthLocation.of_site
method if the--remote-data
option is not used, so that the tests can still resolve coordinates for the observatories in the tests without internet access.This closes #121 and #40.
cc @cdeil, my monkey-patch tutor.