Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sigma clipping benchmarks #55

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Add sigma clipping benchmarks #55

merged 1 commit into from
Jun 15, 2018

Conversation

larrybradley
Copy link
Member

No description provided.

@larrybradley larrybradley mentioned this pull request Jun 15, 2018
Open
pllim
pllim approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pllim
Copy link
Member

pllim commented Jun 15, 2018

@larrybradley said, "The time_3d_array times out currently, but it will be ~10x faster." Merging.

@pllim pllim merged commit 56cffb3 into astropy:master Jun 15, 2018
@astrofrog
Copy link
Member

I think it's not ideal to have it time out before the performance improvement - can we not just use a smaller array?

@larrybradley
Copy link
Member Author

OK.

@larrybradley larrybradley deleted the sigmaclip branch June 15, 2018 21:18
@pllim
Copy link
Member

pllim commented Jun 15, 2018

Ops. Sorry if I merged this too soon.

@larrybradley larrybradley mentioned this pull request Jun 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

Assignees
No one assigned
Labels
new-benchmark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larrybradley @pllim @astrofrog