Update sites.json with CHIME and Galt telescope locations #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamogu
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
Because we merged another pull request which also appended to the bottom on the file first, git had a merge conflict. I've taken the freedom to rebase this, so that you don't have to bother - it's not your fault that this has been sitting for so long.
In [1]: from astropy.coordinates.tests import test_sites
...: test_sites.check_builtin_matches_remote('coordinates/sites.json')
pass and I verified the coordinates in the 2018 paper and compared to an image on Google maps.
Thanks a lot for helping us to make astropy better!
|
Thank you @hamogu ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address the lack of positions of the CHIME telescope and the Dominion Radio Astronomical Observatory (marked by the position of the John Galt telescope) in known sites of astropy.
Fixes #