Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up sunpy config #18

Merged
merged 3 commits into from
Apr 29, 2024
Merged

tidy up sunpy config #18

merged 3 commits into from
Apr 29, 2024

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Apr 16, 2024

Should have no change but it brings it inline with our current version on main

Comment on lines +2 to +3
.hypothesis
result_images
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our tests have some side effects for fun

@nabobalis nabobalis changed the title [do not merge] tidy up sunpy [do not merge] tidy up sunpy config Apr 16, 2024
@nabobalis nabobalis marked this pull request as ready for review April 16, 2024 21:57
@nabobalis nabobalis marked this pull request as draft April 16, 2024 21:58
@nabobalis
Copy link
Contributor Author

nabobalis commented Apr 16, 2024

sunpy-dev is now passing on my branch I have PRed. https://github.com/sunpy/sunpy/pull/7574/files

Link to passing build: https://github.com/astropy/astropy-integration-testing/actions/runs/8713116859/job/23900910674?pr=18 with numpy 2.0rc

Not really sure how to explain it but alas.

@nabobalis nabobalis mentioned this pull request Apr 16, 2024
This reverts commit c72e0c4.
@nabobalis nabobalis marked this pull request as ready for review April 16, 2024 22:18
@nabobalis nabobalis changed the title [do not merge] tidy up sunpy config tidy up sunpy config Apr 16, 2024
@pllim pllim requested a review from astrofrog April 16, 2024 22:51
@astrofrog astrofrog merged commit ea907f7 into astropy:main Apr 29, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants