Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #46 Adds WCSAxes to the affiliated package repo #53

Merged
merged 1 commit into from
Feb 22, 2015

Conversation

sudheesh001
Copy link
Contributor

No description provided.

@astrofrog
Copy link
Member

Thanks @sudheesh001!

astrofrog added a commit that referenced this pull request Feb 22, 2015
Fixes Issue #46 Adds WCSAxes to the affiliated package repo
@astrofrog astrofrog merged commit b05d746 into astropy:master Feb 22, 2015
@eteq
Copy link
Member

eteq commented Mar 13, 2015

@sudheesh001 @astrofrog - one thing I noticed here just now: the "provisional" entry should not be "true", but rather it should be set to a date 1 year from when the package was first accepted as provisional. I'll just fix this in master right now, but I wanted to mention this so we can avoid it in future PRs.

One other tip, @sudheesh001 : if I'm reading this right, merging didn't automatically close this issue. Text like "closes #xxx" in the commit log or issue description does this automatically. I see you do have "closes issue #53" in the log, but it didn't work. I think you have to instead use "closes #53" or "fixes #53" or similar (i.e., no "issue" part). Just FYI - it makes it easier to keep track of all these issues.

(Same comment applies for #54)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants