Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing filesize checking becuase database file sizes are not reliable #1050

Merged
merged 2 commits into from
Feb 21, 2018

Conversation

ceb8
Copy link
Member

@ceb8 ceb8 commented Feb 20, 2018

This is a really minor bugfix that just removes the file size check for downloaded files. This is because right now the database filesizes are not reliably accurate, which will lead to confusing output. We can put this check back in when the database issue is resolved.

@astropy-bot
Copy link

astropy-bot bot commented Feb 20, 2018

Hi there @ceb8 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #1050 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
+ Coverage   64.22%   64.25%   +0.02%     
==========================================
  Files         135      135              
  Lines       10717    10712       -5     
==========================================
  Hits         6883     6883              
+ Misses       3834     3829       -5
Impacted Files Coverage Δ
astroquery/mast/core.py 79.01% <ø> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4149e19...9a33317. Read the comment docs.

@bsipocz bsipocz added the mast label Feb 21, 2018
@bsipocz bsipocz added this to the v0.3.8 milestone Feb 21, 2018
@bsipocz bsipocz merged commit 75b7937 into astropy:master Feb 21, 2018
@bsipocz
Copy link
Member

bsipocz commented Feb 21, 2018

Thanks @ceb8!

@ceb8 ceb8 deleted the bugfix branch February 21, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants