Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed logical issue in astroquery/vizier/core.py #1406

Merged
merged 1 commit into from
May 3, 2019

Conversation

Mamizou
Copy link
Contributor

@Mamizou Mamizou commented Apr 5, 2019

fixed h_box and w_box being switched in some _parse_angle() calls according to Issue #1269

fixed `h_box` and `w_box` being switched in `_parse_angle()` call
@Mamizou Mamizou changed the title updated core.py fixed logical issue in astroquery/vizier/core.py Apr 5, 2019
@bsipocz bsipocz added the vizier label Apr 5, 2019
@bsipocz bsipocz added this to the v0.3.10 milestone Apr 5, 2019
@bsipocz bsipocz added the bug label Apr 5, 2019
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #1406 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1406   +/-   ##
=======================================
  Coverage   64.56%   64.56%           
=======================================
  Files         157      157           
  Lines       12229    12229           
=======================================
  Hits         7896     7896           
  Misses       4333     4333
Impacted Files Coverage Δ
astroquery/vizier/core.py 68.05% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b5c48...1844eb3. Read the comment docs.

@bsipocz bsipocz merged commit ff9403b into astropy:master May 3, 2019
@bsipocz
Copy link
Member

bsipocz commented May 3, 2019

Thanks @Mamizou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants