Add option to silence logger for MAST enable_cloud_dataset() #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
==========================================
- Coverage 62.42% 62.42% -0.01%
==========================================
Files 176 176
Lines 14634 14635 +1
==========================================
Hits 9136 9136
- Misses 5498 5499 +1
Continue to review full report at Codecov.
|
ceb8
reviewed
Aug 19, 2019
| @@ -1561,6 +1561,8 @@ def enable_cloud_dataset(self, provider="AWS", profile=None): | |||
| though at the moment this argument is ignored. | |||
| profile : str | |||
| Profile to use to identify yourself to the cloud provider (usually in ~/.aws/config). | |||
| verbose : bool | |||
| Logger to display extra info and warning. | |||
ceb8
approved these changes
Aug 19, 2019
|
@pllim - I'm on the verge whether this needs a changelog or not, leave it up to you, and will merge once CI is happy. |
|
I cancelled the CI because I plan to add a change log, squash, and then let it run. |
Address review comment by @ceb8 and add change log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be nice if I can silence this without affecting the logger behavior as a whole. I don't need it to remind me about S3 pricing every time I run the function.
🙏 @ceb8 🙏