GAIA: Add optional 'columns' parameter to select specific columns. #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added optional 'columns' parameter to query_object and cone_search so you can select only the desired columns and save bandwidth and meory.
Added optional 'columns' parameter to query_object and cone_search so you can select only the desired columns and save bandwidth and meory.
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
==========================================
+ Coverage 62.42% 62.42% +<.01%
==========================================
Files 176 176
Lines 14635 14641 +6
==========================================
+ Hits 9136 9140 +4
- Misses 5499 5501 +2
Continue to review full report at Codecov.
|
keflavich
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
I like this change. @jcsegovia, could you review? I don't see any reason not to merge this right now.
|
I agree @keflavich, I think it is quite useful and I do not see any problem with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Some of the functions from the Gaia submodule (cone_search and query_object) are lacking a 'columns' parameter to query only for specific columns. Querying only for the desired columns would reduce the bandwidth and memory used every time you query for an object or do a cone search. My version of the code is compatible with old ones, as it adds an optional parameter that behaves just like it used to (in previous versions) if it's not set.