Remove astroquery.lcogt #2071
Merged
Remove astroquery.lcogt #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…years after upstream API refactor
Codecov Report
@@ Coverage Diff @@
## main #2071 +/- ##
==========================================
- Coverage 66.80% 66.66% -0.15%
==========================================
Files 411 406 -5
Lines 27217 26939 -278
==========================================
- Hits 18183 17959 -224
+ Misses 9034 8980 -54 Continue to review full report at Codecov.
|
keflavich
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is not functioning for a number of years due to upstream refactoring the API.
#911 was aiming to fix it, but it needs more work. The removal of the module has been raised a while ago and I think it's probably the best approach for now with emphasizing that adding a working LCO module is a more than welcomed contribution.
Closes #1061