Fixing LCO archive #911

zemogle · 2017-05-11T22:17:33Z

I'm opening this not because this is finished but so you can see the progress. I've not fixed the tests, which is next on my list but I do have working code which can auth with LCO and perform a simple query by object name and date constraints.

keflavich

just some very minor comments

keflavich · 2017-05-12T07:58:11Z

astroquery/lco/__init__.py

+# Licensed under a 3-clause BSD style license - see LICENSE.rst
+"""
+Las Cumbres Observatory public archive Query Tool
+===============


minor style: make the # of ='s same as # of characters above

keflavich · 2017-05-12T07:59:22Z

astroquery/lco/core.py

+
+"""
+Las Cumbres Observatory
+====


keflavich · 2017-05-12T08:05:11Z

astroquery/lco/core.py

+        --------
+        While this section is optional you may put in some examples that
+        show how to use the method. The examples are written similar to
+        standard doctests in python.


just a reminder to remove this reminder text and replace it with something useful

Added some useful text describing data format

eteq

@pep8speaks Suggest a diff

bsipocz · 2017-05-12T09:08:24Z

@eteq - Maybe the config is not properly set yet. Could we have a quick compare during coffeebreak to sunpy's. I'll also open an issue for them to expose the config to non org-wide admins similarly to the CI services.

OrkoHunter

@pep8speaks suggest a diff

astropy-bot · 2018-06-12T10:49:18Z

Check results are now reported in the status checks at the bottom of this page.

zemogle · 2018-06-12T11:23:25Z

Ok, I think I messed something up there. I'm currently working on this not trying to push a new PR. Sorry 😞

bsipocz · 2018-06-12T12:21:40Z

@zemogle: A rebase should solve this all.

assuming with git remote -v you have this:

upstream 	git@brigi.github.com:astropy/astroquery.git (fetch)
upstream 	git@brigi.github.com:astropy/astroquery.git (push)
origin	git@github.com:zemogle/astroquery.git (fetch)
origin	git@github.com:zemogle/astroquery.git (push)

Then git fetch --all and git rebase -i upstream/master. Latter brings up an editor, there please remove the last commit "Merge upstream". When done, git push origin lcogt -f

bsipocz · 2018-06-12T12:23:33Z

There was only a very minor change in the module when I've changed the tests from xfail to skip, so that may cause some conflict but they should be easy to resolve.

zemogle · 2018-06-13T08:56:29Z

I'm having real issues getting the tests to run. I just get this error which looks unrelated to anything I've done:

_____________________________________________ ERROR collecting astroquery/lco/tests/test_lco_remote.py _____________________________________________
/Users/egomez/Applications/anaconda/envs/astroq/lib/python3.6/site-packages/_pytest/python.py:395: in _importtestmodule
    mod = self.fspath.pyimport(ensuresyspath=importmode)
/Users/egomez/Applications/anaconda/envs/astroq/lib/python3.6/site-packages/py/_path/local.py:662: in pyimport
    __import__(modname)
lco/__init__.py:78: in <module>
    from .core import Lco, LcoClass
lco/core.py:43: in <module>
    import keyring
<frozen importlib._bootstrap>:961: in _find_and_load
    ???
<frozen importlib._bootstrap>:950: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:646: in _load_unlocked
    ???
<frozen importlib._bootstrap>:616: in _load_backward_compatible
    ???
/Users/egomez/Applications/anaconda/envs/astroq/lib/python3.6/site-packages/keyring-12.2.1-py3.6.egg/keyring/__init__.py:3: in <module>
    ???
<frozen importlib._bootstrap>:961: in _find_and_load
    ???
<frozen importlib._bootstrap>:950: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:646: in _load_unlocked
    ???
<frozen importlib._bootstrap>:616: in _load_backward_compatible
    ???
/Users/egomez/Applications/anaconda/envs/astroq/lib/python3.6/site-packages/keyring-12.2.1-py3.6.egg/keyring/core.py:13: in <module>
    ???
<frozen importlib._bootstrap>:961: in _find_and_load
    ???
<frozen importlib._bootstrap>:950: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:646: in _load_unlocked
    ???
<frozen importlib._bootstrap>:616: in _load_backward_compatible
    ???
/Users/egomez/Applications/anaconda/envs/astroq/lib/python3.6/site-packages/keyring-12.2.1-py3.6.egg/keyring/backend.py:10: in <module>
    ???
<frozen importlib._bootstrap>:961: in _find_and_load
    ???
<frozen importlib._bootstrap>:946: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:885: in _find_spec
    ???
<frozen importlib._bootstrap_external>:1157: in find_spec
    ???
<frozen importlib._bootstrap_external>:1131: in _get_spec
    ???
<frozen importlib._bootstrap_external>:1112: in _legacy_get_spec
    ???
<frozen importlib._bootstrap>:427: in spec_from_loader
    ???
<frozen importlib._bootstrap_external>:544: in spec_from_file_location
    ???
E     File "/Users/egomez/Applications/anaconda/envs/astroq/lib/python3.6/site-packages/entrypoints-0.2.3-py3.6.egg/entrypoints.py", line 98
E   SyntaxError: invalid escape sequence \s

keflavich · 2018-06-13T14:51:28Z

Oh I've seen that before... but I think I saw it in beautifulsoup. It is some weird issue related to python3 rejecting "bad" string escape sequences. I don't remember how I solved it, unfortunately, but maybe try updating keyring?

bsipocz · 2018-06-13T16:25:22Z

I can't recall seeing this issue before.

zemogle · 2018-06-13T20:34:09Z

The issue above was solved by down-grading keyring==11.0.0. The library is functional and I've added some tests.

bsipocz · 2018-06-17T17:31:51Z

@zemogle - would you also add some narrative docs and examples?

zemogle added 2 commits May 11, 2017 19:18

Updating and moving LCOGT to LCO

b6d758c

Look up named object, filter by date and auth

09c9d3b

bsipocz added the lco label May 11, 2017

Removing template comments

a62ef94

keflavich reviewed May 12, 2017

View reviewed changes

eteq reviewed May 12, 2017

View reviewed changes

Adding helpful text

4c7b368

OrkoHunter reviewed May 12, 2017

View reviewed changes

OrkoHunter mentioned this pull request May 12, 2017

Expose config to non org-wide admins pep8speaks-org/pep8speaks#45

Closed

bsipocz mentioned this pull request Mar 2, 2018

Deprecated service: LCOGT #1061

Closed

bsipocz force-pushed the master branch 2 times, most recently from ab0c591 to 712c326 Compare June 8, 2018 12:58

Merging upstream

d8e7417

bsipocz added the Work in progress label Jun 12, 2018

zemogle added 3 commits June 13, 2018 09:22

Adding test data

e0cdef9

Removing old files

727feca

Updating tests

cfc5bc9

zemogle added 2 commits June 13, 2018 21:23

removing obsolete tests

2a88109

Merging from master

e969680

zemogle added 2 commits June 13, 2018 21:46

Adding missing helper classes

bf23071

refixing problems from merge conflict

beb4453

bsipocz removed the Work in progress label Jun 17, 2018

bsipocz added this to the v0.3.9 milestone Jun 17, 2018

astropy deleted a comment from pep8speaks Jun 17, 2018

bsipocz modified the milestones: v0.3.9, v0.3.10 Dec 6, 2018

bsipocz removed this from the v0.3.10 milestone Jun 3, 2019

bsipocz mentioned this pull request May 14, 2021

Remove astroquery.lcogt #2071

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing LCO archive #911

Fixing LCO archive #911

zemogle commented May 11, 2017

keflavich left a comment

keflavich May 12, 2017

keflavich May 12, 2017

keflavich May 12, 2017

zemogle May 12, 2017

eteq left a comment

bsipocz commented May 12, 2017

OrkoHunter left a comment

astropy-bot bot commented Jun 12, 2018 •

edited

zemogle commented Jun 12, 2018

bsipocz commented Jun 12, 2018

bsipocz commented Jun 12, 2018

zemogle commented Jun 13, 2018

keflavich commented Jun 13, 2018

bsipocz commented Jun 13, 2018

zemogle commented Jun 13, 2018

bsipocz commented Jun 17, 2018

Fixing LCO archive #911

Are you sure you want to change the base?

Fixing LCO archive #911

Conversation

zemogle commented May 11, 2017

keflavich left a comment

Choose a reason for hiding this comment

keflavich May 12, 2017

Choose a reason for hiding this comment

keflavich May 12, 2017

Choose a reason for hiding this comment

keflavich May 12, 2017

Choose a reason for hiding this comment

zemogle May 12, 2017

Choose a reason for hiding this comment

eteq left a comment

Choose a reason for hiding this comment

bsipocz commented May 12, 2017

OrkoHunter left a comment

Choose a reason for hiding this comment

astropy-bot bot commented Jun 12, 2018 • edited

zemogle commented Jun 12, 2018

bsipocz commented Jun 12, 2018

bsipocz commented Jun 12, 2018

zemogle commented Jun 13, 2018

keflavich commented Jun 13, 2018

bsipocz commented Jun 13, 2018

zemogle commented Jun 13, 2018

bsipocz commented Jun 17, 2018

astropy-bot bot commented Jun 12, 2018 •

edited